Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[OptionsResolver] Update nested options examples to usesetOptions instead ofsetDefault#20719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| Defining nested option via :method:`Symfony\\Component\\OptionsResolver\\OptionsResolver::setDefault` | ||
| was deprecated since Symfony 7.3, use the :method:`Symfony\\Component\\OptionsResolver\\OptionsResolver::setOptions` | ||
| instead. Allowing to define default values for prototyped options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure about this deprecation block. Is it needed in this case, or would the replacement + versionadded note be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, sometimes it's difficult to decide if we should add such a block. At the end, I left it so anyone searching for "setDefault" can still find this page. Thanks!
1da928a intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Yonel, thanks for this nice contribution! |
closes#20705
PRsymfony/symfony#59618