Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Documentrequire_tls option#20701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ssddanbrown
Copy link
Contributor

For#20644. This PR documents the added SMTPrequire_tls option, as introduced insymfony/symfony#59479.

I have referenced that this could throw aTransportException (where TLS is not achieved) but not sure if I should instead referenceTransportExceptionInterface.

@OskarStarkOskarStark changed the title[Mailer] Document require_tls option[Mailer] Documentrequire_tls optionMar 10, 2025
Copy link
Contributor

@mdoutreluingnemdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To have the same "naming" as the other versionadded directive when adding an new option

mailer.rst Outdated
@@ -420,6 +420,29 @@ setting the ``auto_tls`` option to ``false`` in the DSN::

This setting only works when the ``smtp://`` protocol is used.

Require use of TLS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe:

Suggested change
Require use of TLS
Enforce TLS

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Happy to change if preferred, butEnforce feels slightly less accurate to me.Enforce sounds like it'd change/force the connection in some manner and/or force TLS upon the whole connection process, whereas this option doesn't change the connection in any way, just ensures it's eventually used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I understand your concern about the term "Enforce" and I agree with you.
What do you think about "Ensure TLS" instead? It might better reflect that the option guarantees the use of TLS without actively altering the connection.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Spomky Sorry for the late response. I agree that "Ensure TLS" would be better. I've updated the heading to that.

Spomky reacted with thumbs up emoji
@javiereguiluzjaviereguiluzforce-pushed themailer_document_require_tls_option branch from4cb9b50 to55217dcCompareMay 8, 2025 08:04
@javiereguiluzjaviereguiluz merged commit7d360e6 intosymfony:7.3May 8, 2025
3 checks passed
@javiereguiluz
Copy link
Member

Dan, thanks a lot for providing these docs! Sorry it took us so long to merge it. Congrats on your first Symfony Docs contribution 🎉

ssddanbrown reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@SpomkySpomkySpomky approved these changes

@xabbuhxabbuhxabbuh approved these changes

@mdoutreluingnemdoutreluingnemdoutreluingne approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

7 participants
@ssddanbrown@javiereguiluz@OskarStark@Spomky@xabbuh@mdoutreluingne@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp