Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer][JsonStreamer] Add streaming JSON documentation#20486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mtarld wants to merge1 commit intosymfony:7.3
base:7.3
Choose a base branch
Loading
frommtarld:feat/json-encoder

Conversation

mtarld
Copy link
Contributor

@mtarldmtarld commentedDec 19, 2024
edited
Loading

@carsonbotcarsonbot added this to the7.3 milestoneDec 19, 2024
@mtarldmtarldforce-pushed thefeat/json-encoder branch 2 times, most recently from592f9aa toafa08c8CompareDecember 20, 2024 15:41
@mtarld
Copy link
ContributorAuthor

The remaining failure is due to the fact that thehttps://github.com/symfony-tools/symfony-application application does not have thesrc/Encodable folder.

Should we create it? Or should we add the issue to the baseline? Or maybe commenting that configuration?

@wouterj
Copy link
Member

wouterj commentedDec 21, 2024
edited
Loading

Hi@mtarld. Thanks a lot for starting this and providing so much valuable documentation early in the development phase!

Before reviewing the whole document, we must think about the position of the component in the documentation. We've mostly stopped using thecomponents/ directory. Instead, we focus on the "guides" and document framework usage. This component is a bit more challenging, as it belongs to the "Serialization" topic that currently belongs to the Serializer component. We've discussed this a bit with the core team during the SymfonyCon:

I think the best way would be to move this article toserializer/json_encoder.rst, and add a little section at the start ofserializer.rst mentioning this component and when you should use instead of the Serializer component (e.g. a compact version of the "Serializer or JsonEncoder?" section). But we're of course open if people have better ideas on how to position this new component in the ecosystem!


Something that might also be interesting is adding aphp-standalone tab to some of the code examples, showing how to use this component standalone. You can see this in use in the mainserializer.rst for instance.

mtarld reacted with thumbs up emoji

@SirRFI
Copy link
Contributor

The documentation requires update, because the component and it's contents has been renamed - seesymfony/symfony#59863

@SirRFI
Copy link
Contributor

Can you provide minimum code required to use the component in custom service inside Symfony project? Could be also useful for "New in Symfony 7.3" blog series.

I tried following the documentation (with updated names), but I getSymfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "Symfony\Component\JsonStreamer\StreamReaderInterface". despite it's visible inbin/console debug:container. Also triedjson.stream_reader alias. All Symfony dependencies are updated to7.3.*-dev.

@mtarld
Copy link
ContributorAuthor

Hey@SirRFI , thanks for keeping track of it. I'm aware of these points yes! 🙂

I'm really busy these days, but as soon as I have time, I'll update this PR (containing your suggestions) - it's part of my top priorities.

@mtarldmtarld changed the title[JsonEncoder] Add component documentation[Serializer] [JsonStreamer] Add streaming JSON documentationApr 27, 2025
@mtarldmtarldforce-pushed thefeat/json-encoder branch 2 times, most recently from0e63875 tofb3e6c6CompareApril 27, 2025 08:42
@OskarStarkOskarStark changed the title[Serializer] [JsonStreamer] Add streaming JSON documentation[Serializer][JsonStreamer] Add streaming JSON documentationMay 9, 2025
@mtarldmtarld requested a review fromwouterjMay 20, 2025 11:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alamiraultalamiraultalamirault left review comments

@MrYamousMrYamousMrYamous left review comments

@TheoD02TheoD02TheoD02 left review comments

@wouterjwouterjAwaiting requested review from wouterj

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Serializer] [JsonEncoder] Introducing the component
7 participants
@mtarld@wouterj@SirRFI@alamirault@MrYamous@TheoD02@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp