Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

update controller return value#20411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Florian-Merle
Copy link
Contributor

A controller is not required to return aResponse object anymore.

@carsonbotcarsonbot added this to the5.4 milestoneNov 26, 2024
@Florian-MerleFlorian-Merle changed the titleupdate controller return value docupdate controller return valueNov 26, 2024
@javiereguiluzjaviereguiluz merged commit6b75287 intosymfony:5.4Nov 26, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Florian for this contribution! However, while merging we did some rewording (seed019fc4).

It's not that your contribution was wrong, but the Controllers chapter in the docs is special. It's one of those that newcomers read first. So, we must be extra careful with anything we mention in them.

The original contribution could introduce some confusion in newcomers because it mentions events and listeners when they haven't been introduced yet.

So, in the reword, we still mention events but as an advanced feature that they'll learn about later. We think this provides a better balance between being technically correct and keep this chapter very approachable for newcomers.

Cheers!

alexislefebvre, Florian-Merle, and chalasr reacted with thumbs up emoji

@Florian-MerleFlorian-Merle deleted the fix/controller-config branchNovember 26, 2024 17:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@MrYamousMrYamousMrYamous approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Florian-Merle@javiereguiluz@MrYamous@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp