Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added Exception and tweaked language of Abstract#2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| @@ -108,12 +108,16 @@ Naming Conventions | |||
| * Use namespaces for all classes; | |||
| *Abstractclassesare often prefixed with``Abstract``; | |||
| *Prefix abstractclasses ``Abstract``; Please note some early Symfony2 classes | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should replace; with.
@wouterj - thanks for the tweak, I'm committed and squashed it. |
weaverryan added a commit that referenced this pull requestDec 18, 2012
Added Exception and tweaked language of Abstract
Hi Drak! Looks great to me and thanks for the conversation on#922 :) Thanks! |
weaverryan added a commit that referenced this pull requestDec 19, 2012
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the case for Exception classes which is followed everywhere.
I've suggested some language to explain why some classes do not follow the
Abstractprefix, but since it is being adhered to for all new stuff since quite a while now (and followed by many large OSS projects), it's important the language is definitive with an explanation.Refs#922