Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Reference/Validation Constraints] Add some missing xml reference examples.#2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

l3l0
Copy link
Contributor

  • Added missing xml examples for: Blank, Length, NotBlank, NotNull, Null
  • Fix MinLength xml example

weaverryan added a commit that referenced this pull requestDec 16, 2012
…eference[Reference/Validation Constraints] Add some missing xml reference examples.
@weaverryanweaverryan merged commit816bba8 intosymfony:2.1Dec 16, 2012
@weaverryan
Copy link
Member

Hi Leszek!

Ah, this is great man! You can see that we don't have enough people looking at our XML examples, so thanks so much for doing this. I was also able to backport most of these changes to the 2.0 branch as well.

Thanks!

@wouterj
Copy link
Member

👍 for this, it was on my todo list to do in 2013.@weaverryan there are some other formats missing as well in code examples, it is maybe an idea to index where which format is missing to get someone looking at it?

@weaverryan
Copy link
Member

@wouterj that would be kind of fun :), someone just needs to write it (i.e. parse through the files for these blocks to see which are missing). Then we could at least run that little script from time-to-time to figure out where we're missing things. Going forward, we would ideally not merge anything without all formats, but in reality, some formats aren't used as much, so I tend to like to merge more quickly and add those other formats later. If we could get a quick list of missing places, that would certainly be cool!

@wouterj
Copy link
Member

@weaverryan ok, I'm on it! 🚂

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@l3l0@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp