Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[DependencyInjection] Add mentions where to find configCache#20035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
sukhoy94 commentedJul 11, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@carsonbot can someone review it? 🙏 |
Uh oh!
There was an error while loading.Please reload this page.
@alexandre-daubois thx for suggestions :) |
| @@ -500,7 +500,8 @@ serves at dumping the compiled container:: | |||
| The ``file_put_contents()`` function is not atomic. That could cause issues | |||
| in a production environment with multiple concurrent requests. Instead, use | |||
| the :ref:`dumpFile() method <filesystem-dumpfile>` from Symfony Filesystem | |||
| component or other methods provided by Symfony (e.g. ``$containerConfigCache->write()``) | |||
| component or other methods provided by Symfony (e.g. ``$containerConfigCache->write()`` | |||
| which is part of the :doc:`Config component </components/config>`) | |||
| which are atomic. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the atomic part relates to the method, not to the config component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@OskarStark true, my point is just to mention where $containerConfigCache->write() may be found.
I think now it's correct, the part
which are atomic.goes after brackets and refers to component or other methods provided by Symfony
bbf4764 intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
Merged! Thanks Andrii. |
Added mention where to find ConfigCache class. To be used in $containerCache->write()