Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added cookbook entry about FrameworkBundle:TemplateController#2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use double backtricks to indicate inline code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No problem, but what is a single backtick used for? Found it somewhere else (cookbook/templating/twig_extension.rst) and assumed, that they were used for keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
They are used for hyperlinks:
This is some text with `A hyperlink`_ and you can refer to a doc article: :doc:`/cookbook/templating/twig_extension` .. _`A hyperlink`: http://symfony.com/stof commentedDec 5, 2012
@weaverryan The support of caching is new in 2.2 but the controller itself is a 2.0 feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
there is a missing: here.
kingcrunch commentedDec 11, 2012
Fix the missing colon, rebased and squashed. Hopefully now? :X |
…atures and proofreadingThe caching stuff will be added back on the master branch
weaverryan commentedDec 26, 2012
Hi Sebastian! Thanks for the PR - I patched it originally into the 2.0 branch at sha:8cbd129, since this is documenting a feature that's been available since 2.0, but wasn't documented yet (and I'm very happy to have it documented now!). I then removed the 2.2-only features at sha:fa6fdee, merged up to master, then re-added those to master only at sha:42b698d. Additionally, things needed to be updated now for the change to how If you see any issues at all, please let me know! Thanks! |
Seesymfony/symfony#6083
Added docbook entry about
FrameworkBundle:TemplateController. I hope, that's ok so far.