Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[TypeInfo] Better explain thegetBaseType() method#20017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:7.1fromjaviereguiluz:fix_19843
Jul 8, 2024

Conversation

@javiereguiluz
Copy link
Member

Fixes#19843.

@mtarld if you have some time, please review this PR. Thanks a lot!

@mtarld
Copy link
Contributor

@javiereguiluz, I just created the PRsymfony/symfony#57630 which rethinks and improves the component design and usage.

Therefore, I'd wait for this PR to be either merged or closed before going further 🙂

@javiereguiluz
Copy link
MemberAuthor

Thanks Mathias ... but this PR only adds some short explanations about existing code examples. Even if your PR is accepted, it will merged in 7.2 branch, so I think it's OK to change this in 7.1 branch meanwhile.

OskarStark and mtarld reacted with thumbs up emoji

@OskarStarkOskarStark changed the title[TypeInfo] Better explain the getBaseType() method[TypeInfo] Better explain thegetBaseType() methodJul 4, 2024
@javiereguiluzjaviereguiluz merged commit3780287 intosymfony:7.1Jul 8, 2024
@javiereguiluzjaviereguiluz deleted the fix_19843 branchJuly 8, 2024 08:34
@javiereguiluz
Copy link
MemberAuthor

Merged for the reasons explained above. If the changes proposed in the new code PR are merged, we'll keep updating these docs. Thanks.

mtarld reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[TypeInfo] Ease getting base type on nullable types

4 participants

@javiereguiluz@mtarld@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp