Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Add missing XML serializer's CDATA options#19883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexpozzi
Copy link
Contributor

Fixes#19851

@carsonbotcarsonbot added this to the7.1 milestoneMay 13, 2024
@alexpozzialexpozzi changed the titleAdd missing XML serializer's CDATA options[Serializer] Add missing XML serializer's CDATA optionsMay 14, 2024
@OskarStark
Copy link
Contributor

#18155 should be merged first

alexpozzi reacted with thumbs up emoji

@OskarStark
Copy link
Contributor

Please add a versionadded directive for your new option

alexpozzi reacted with thumbs up emoji

@OskarStark
Copy link
Contributor

OskarStark commentedMay 16, 2024•
edited
Loading

#18155 should be merged first

Done, please rebase

alexpozzi reacted with thumbs up emoji

@alexpozzialexpozziforce-pushed theadd_missing_xml_serializer_options branch fromcc4bcd4 to53aeff4CompareMay 16, 2024 07:03
containing one of the following characters (
``<``, ``>``, ``&``) in `a CDATA section`_ like
following: ``<![CDATA[...]]>``
matching the `cdata_wrapping_pattern`_ regex in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

where is the defined link for data_wrapping_pattern?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mistake, sorry, I didn't want to make a link

OskarStark reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

btw I fixed the DOCtor-RST build. I should be green after another rebase

alexpozzi reacted with thumbs up emoji

@alexpozzialexpozziforce-pushed theadd_missing_xml_serializer_options branch from53aeff4 tof178e95CompareMay 16, 2024 11:33
@alexpozzialexpozziforce-pushed theadd_missing_xml_serializer_options branch fromf178e95 toc6d3512CompareMay 16, 2024 11:34
@OskarStark
Copy link
Contributor

Thank you Alessandro.

alexpozzi reacted with heart emoji

@OskarStarkOskarStark merged commit4a052d5 intosymfony:7.1May 16, 2024
@alexpozzialexpozzi deleted the add_missing_xml_serializer_options branchMay 16, 2024 11:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkAwaiting requested review from OskarStark

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[Serializer] AddXmlEncoder::CDATA_WRAPPING_PATTERN context option

3 participants

@alexpozzi@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp