Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added max-width and changed figure to image#1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hey! I remember a LONG time ago trying to decide between using I'm not sure either how this might end up looking when we render it in the PDF - it might have no effect at all, I just don't know! What do you think about making the image itself a bit smaller? |
Oh, wow, I really missed that caption. They should be styled better in the documentation. Now it looks like the caption is just the normal content, which leads to mixed semantics and a less readable docs. It looks the same (no style) inside the PDF. A simple margin like It seems that images are scaled down automatic in PDF (see image below). Scaling down the images themselves is a lot better, if it is done with the right tool. It will decrease page load time (a little bit) and it solves the confusing how it works in the PDF. It is maybe an idea to put something like this inside the symfony.com stylesheet, to make sure images aren't wider than the content:
|
@wouterj +1 for making the image just a little bit smaller to fit on the page naturally, at its full width Do you want to do that? And about the CSS, can you open another issue on that - then I'll tag it with Thanks! |
@weaverryan I will create a new issue for the CSS and when I get some better image editor than Paint, I will resize the image. |
@weaverryan I have created an issue (#2034) and updated this PR to only resize the image, it should be ready to merge now. |
Added max-width and changed figure to image
Awesome all around! The captions look much much better now on the site (... needs a force-refresh to see them) |
We should use the
.. image::
directive as the figure is for images with captions and we should add a max-width of690px
so the images don't breakout of the content section.