Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add documentation for#[MapUploadedFile] attribute#19807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:7.1fromrenedelima:map-uploaded-file
May 8, 2024

Conversation

renedelima
Copy link
Contributor

@renedelimarenedelima commentedApr 19, 2024
edited
Loading

Closes#19802

@carsonbotcarsonbot added this to the7.1 milestoneApr 19, 2024
@OskarStarkOskarStark changed the titleAdd documentation for #[MapUploadedFile] attributeAdd documentation for#[MapUploadedFile] attributeApr 19, 2024
@renedelimarenedelimaforce-pushed themap-uploaded-file branch 17 times, most recently from15e622c to2b78938CompareApril 20, 2024 09:27
@renedelima
Copy link
ContributorAuthor

renedelima commentedApr 20, 2024
edited
Loading

@OskarStark I applied your suggestions, fixed theCode blocks check, and made some other changes. The PR is now ready for review.

@renedelimarenedelimaforce-pushed themap-uploaded-file branch 5 times, most recently from5f01462 to2760f35CompareApril 22, 2024 18:58
@mttsch
Copy link
Contributor

Should the attribute also be added tohttps://symfony.com/doc/7.1/reference/attributes.html#httpkernel?

renedelima reacted with thumbs up emoji

@renedelimarenedelimaforce-pushed themap-uploaded-file branch 7 times, most recently fromc595ebc to5cd1964CompareApril 22, 2024 20:32
@renedelima
Copy link
ContributorAuthor

Should the attribute also be added tohttps://symfony.com/doc/7.1/reference/attributes.html#httpkernel?

The link was added.

@javiereguiluzjaviereguiluz merged commit630cac8 intosymfony:7.1May 8, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Renê, thanks a lot for adding these docs ... and congrats on your first Symfony Docs contribution 🎉

What a beautiful contribution you did to Symfony code (and docs too!). Tomorrow I'll publish a "New in Symfony 7.1" post dedicated to this.

Note: while merging I did some tweaks and rewords. See846cbae. It looks like I changed a ton of things, but it's not true:

  • I changed the order to display first the simple example with no constraints
  • I changed the style of the controllers to show a standard controller extending AbstractController instead of an invokable controller (your original example is perfectly correct, but this article is one of the basic chapters of Symfony Docs, so I prefer to keep the same basic style as in the rest of the page)
  • Other minor tweaks

So, most of your contribution stays. Thanks!

renedelima reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[HttpKernel] Introduce#[MapUploadedFile] controller argument attribu…
6 participants
@renedelima@mttsch@javiereguiluz@OskarStark@alexandre-daubois@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp