Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Emoji][Twig] Addemojify filter#19773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lyrixx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One little comment, otherwise 👍🏼
Uh oh!
There was an error while loading.Please reload this page.
lyrixx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
alamirault left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you Javier, I made some comments
| ``text`` | ||
| **type**: ``string`` | ||
| ``catalog`` *(optional)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When is null, default extension catalog is applied. It's "text" by default in construct.
I don't remember what is text behavior, but we should discribe this default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
text locale must be documented first#19745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I created#19919
| ..code-block::twig | ||
| {{ ':+1:'|emojify }} {# renders: 👍 #} | ||
| {{ ':+1:'|emojify('github') }} {# renders: 👍 #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is the rendering of an unknown value for the catalog ?
Adding an example could be great !
OskarStark commentedMay 15, 2024
Friendly ping@javiereguiluz |
javiereguiluz commentedJun 17, 2024
I rebased and added more examples. |
emojify filterUh oh!
There was an error while loading.Please reload this page.
Fixes#19756.
@lyrixx if you can, please review this. Thanks!