symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

[Clock] Document createFromTimestamp() method#19768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit into7.1fromfix_19766

Apr 10, 2024

Merged

[Clock] Document createFromTimestamp() method#19768

javiereguiluz merged 1 commit into7.1fromfix_19766

Apr 10, 2024

Conversation

Copy link

Member

javiereguiluz commentedApr 9, 2024

Fixes#19766

javiereguiluz added the Clock label

Apr 9, 2024

javiereguiluz added this to the7.1 milestone

Apr 9, 2024

carsonbot added the Status: Needs Review label

Apr 9, 2024

xabbuh reviewed

Apr 10, 2024

View reviewed changes

components/clock.rst OutdatedShow resolvedHide resolved

xabbuh reviewed

Apr 10, 2024

View reviewed changes

components/clock.rst OutdatedShow resolvedHide resolved

xabbuh reviewed

Apr 10, 2024

View reviewed changes

components/clock.rst OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

javiereguiluz commentedApr 10, 2024

@xabbuh thanks for your review and I'm sorry for these gross mistakes. I was in a rush and I committed without a proper review first. Everything is fixed now. Thanks!

xabbuh approved these changes

Apr 10, 2024

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 10, 2024

[Clock] Document createFromTimestamp() method

9bd321d

javiereguiluz force-pushed thefix_19766 branch from745d440 to9bd321dCompare

April 10, 2024 13:30

Copy link

Member

derrabus commentedApr 10, 2024

Thank you for your work on this,@javiereguiluz!

I think, it is worth mentioning that this method is part of a set of (more undocumented) polyfills. ThecreateFromTimestamp() method will be added toDateTimeImmutable (and thus to ourDatePoint class as well) in PHP 8.4. My polyfill makes this functionality available on PHP 8.2 already. The other polyfilled methods that have existed before my PR already aresetMicrosecond() andgetMicrosecond(), both added by@nicolas-grekas insymfony/symfony#53942.