Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Serializer] Fix recursive custom normalizer#19532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Yes, the solution proposed in this PR looks more elegant than the one you showed in the comment above. Thanks Mathias! |
autowiring only the object normalizer is a bad idea to me, because it assumes that no other normalizer than the ObjectNormalizer should be responsible for the delegated call. Note that depending on the context for the support here is not that bad: |
As mentioned in the following issue:symfony/symfony#53708, the example showing how to create a custom normalizer leads to an infinite recursion.
I could have been fixed like that:
class TopicNormalizer implements NormalizerInterface, NormalizerAwareInterface{ use NormalizerAwareTrait;+ private const ALREADY_CALLED = self::class.'_already_called';+ public function __construct( private UrlGeneratorInterface $router, ) { } public function normalize($topic, string $format = null, array $context = []): array {+ $context[self::ALREADY_CALLED] = true;+ $data = $this->normalizer->normalize($topic, $format, $context); // Here, add, edit, or delete some data: $data['href']['self'] = $this->router->generate('topic_show', [ 'id' => $topic->getId(), ], UrlGeneratorInterface::ABSOLUTE_URL); return $data; } public function supportsNormalization($data, string $format = null, array $context = []): bool {+ if ($context[self::ALREADY_CALLED] ?? false) {+ return false;+ }+ return $data instanceof Topic; } public function getSupportedTypes(?string $format): array { return [- Topic::class => true,+ Topic::class => false, ]; }}But this will prevent the normalizer to be cacheable (because it depends on the context).
Instead, I dropped the use of
NormalizerAwareInterfaceandNormalizerAwareTraitand used an explicit constructor injection instead.WDYT?