Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Emoji] Emoji component#19489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:7.1fromsmnandre:doc/emoji-component
Mar 11, 2024

Conversation

@smnandre
Copy link
Member

@smnandresmnandre commentedFeb 3, 2024
edited by xabbuh
Loading

Emoji documentation

(Issue:#19484)

@carsonbotcarsonbot added this to the7.1 milestoneFeb 3, 2024
@smnandresmnandre marked this pull request as draftFebruary 3, 2024 15:00
@smnandresmnandre changed the titleEmoji component [WIP]Emoji componentFeb 16, 2024
@smnandresmnandre marked this pull request as ready for reviewFebruary 16, 2024 08:24
@xabbuhxabbuh added the Emoji labelFeb 16, 2024
@carsonbotcarsonbot changed the titleEmoji component[Emoji] Emoji componentFeb 16, 2024
@smnandre
Copy link
MemberAuthor

Run ../_checker/code-block-checker.php verify:docs `pwd` components/emoji.rst components/intl.rst  --baseline=baseline.json --output-format=github --symfony-application=`realpath ../_sf_app`Error: [Missing class] Class, interface or trait with name "Symfony\Component\Emoji\EmojiTransliterator" does not existError: [Missing class] Class, interface or trait with name "Symfony\Component\Emoji\EmojiTransliterator" does not existError: Process completed with exit code 1.

Does that mean Emoji component must be added to the symfony app ?

@smnandre
Copy link
MemberAuthor

Thank you for the feedback@javiereguiluz !

The CI stays red (will stay red until we add "emoji" to the stimulus app used in this CI workflow i think)

Anything i can add / imrpove ?

@javiereguiluzjaviereguiluz merged commit48c932d intosymfony:7.1Mar 11, 2024
@javiereguiluz
Copy link
Member

Simon, thanks a lot for this 🙌 This is now merged!

Note that while merging we reorganized contents a bit. We discussed internally in the Symfony Docs team and decided to do so because we don't want to add new docs undercomponents/ namespace. We want to remove allcomponents/ docs and move it to normal articles. So, we've deletedcomponents/emoji.rst and moved its contents tocomponents/string.rst (see9333df7). In a future PR we're going to movecomponents/string.rst tostring.rst. Thanks!

smnandre reacted with thumbs up emoji

@smnandre
Copy link
MemberAuthor

We discussed internally in the Symfony Docs team and decided to do so because we don't want to add new docs under components/ namespace.

Ok noted for the future

Note that while merging we reorganized contents a bit.

Thanks for the heads up and explanation! Makes a lot of sense :)

javiereguiluz added a commit that referenced this pull requestMar 14, 2024
…iluz)This PR was merged into the 7.1 branch.Discussion----------[String] Reorganize String component contentsAs mentioned in#19489, we want to move contents out from `components/`. This PR moves String to its own root-level article.Commits-------d4aed27 [String] Reorganize String component contents
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzAwaiting requested review from javiereguiluz

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@smnandre@javiereguiluz@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp