The reason looks confusing to me. How is it possible to lose decimals when the divisor is1?

Looking at the implementation, it seems more related to the fact that theinteger value doesn't have any effect when the divisor is1.

I misspoke, it is in fact linked to theinteger with a divisor is1.

I find that the caution message is no longer useful. What do you think?

@mdoutreluingne I still don't understand this caution. But it's not because of your PR. I've checked the code and I don't understand it either. I also read this discussion and I still don't understand it:symfony/symfony#51884 (comment)

How would you explain this in a way that anybody can understand it? Thanks.

@javiereguiluz

From what I've understood from looking at the implementation, an exception is thrown if themodel_type isinteger and the divisor is1, because according tothis condition the casting is only done if the divisor is not equal to1, otherwise it only returns the value entered.

Me too, I don't understand why an exception is thrown if the divisor equals1. Casting can be done perfectly well if the divisor is equal to1.

I've added this caution message to warn the reader that if he changes themodel_type forinteger, he must also change thedivisor (because the default divisor value is1), otherwise an exception will be thrown.

But maybe I've added a message that is ultimately of no interest to the reader and the message of the exception is enough.

What do you think?

Yes, I think it's better to not add this to the docs. Developers will get a explict exception message if they do "wrong".

But, maybe we should revisit this or refactor the code to make it easier to understand. It seems that nobody truly understands this code 😐

Removing caution message done.

I agree, I think it should be refactor the code to make it easier to understand.

I've openedsymfony/symfony#53488 to see if we can finally understand the reason of this code. Thanks.