Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Webhook] Added component documentation for use in combination with Mailer#19249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:6.3fromTimoBakx:webhook
Dec 12, 2023

Conversation

@TimoBakx
Copy link
Member

@TimoBakxTimoBakx commentedDec 9, 2023•
edited by OskarStark
Loading

OskarStark, welcoMattic, MaSpeng, alexandre-daubois, and sanderbongers reacted with heart emoji
Copy link

@dsdeboerdsdeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👏

@OskarStark
Copy link
Contributor

A personal big big thank you for driving this forward. Thank you Timo 🙏

TimoBakx reacted with heart emoji

@OskarStark
Copy link
Contributor

Please rebase on 6.3, thanks

TimoBakx reacted with thumbs up emoji

@alexandre-daubois
Copy link
Member

Congrats on this new version 🥳

@TimoBakx
Copy link
MemberAuthor

TimoBakx commentedDec 9, 2023•
edited
Loading

@OskarStark thank you for reminding me.

The code block check fails due to Webhook not being installed in the test application (symfony-tools/symfony-application). Should I add it there?

@MrYamous
Copy link
Contributor

I am glad to see some news for this component documentation, congratulations

OskarStark reacted with thumbs up emoji

@TimoBakx
Copy link
MemberAuthor

Thank you@MrYamous and@OskarStark for the feedback. I've updated everything accordingly.

OskarStark reacted with heart emoji

@OskarStark
Copy link
Contributor

Can you please rebase? I fixed the Build error

OskarStark added a commit that referenced this pull requestDec 12, 2023
…ew (OskarStark)This PR was squashed before being merged into the 6.3 branch.Discussion----------[Mailer] Mention webhook support in Mailer bridge overviewRefs*#19249cc `@MrYamous` `@TimoBakx`What do you think about this?Do we have other bridges which supporting webhook since 6.3 ? 🤔Commits-------d8c2c3b [Mailer] Mention webhook support in Mailer bridge overview
@TimoBakx
Copy link
MemberAuthor

@OskarStark Rebased & squashed.

@OskarStark
Copy link
Contributor

Big big thank you!

@OskarStarkOskarStark merged commit0b58658 intosymfony:6.3Dec 12, 2023
@OskarStark
Copy link
Contributor

Maybe someone can provide more infos about which bridges support webhooks in mailer.rst starting from 6.4 branch

@alexandre-daubois
Copy link
Member

Congrats! 😃

I'm looking at bridges 👍

@TimoBakx
Copy link
MemberAuthor

Maybe someone can provide more infos about which bridges support webhooks in mailer.rst starting from 6.4 branch

Working in the PRs for those. :)

@OskarStark
Copy link
Contributor

Only one please :-D

@TimoBakx
Copy link
MemberAuthor

Only one please :-D

Sorry, I was too fast. >_<

OskarStark added a commit that referenced this pull requestDec 12, 2023
…) (TimoBakx)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Webhook] Added Sendgrid's webhook support (added in 6.4)Follow-up of#19249Commits-------b8d08cb [Webhook] Added Sendgrid's webhook support (added in 6.4)
@TimoBakxTimoBakx deleted the webhook branchDecember 12, 2023 11:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@fabpotfabpotAwaiting requested review from fabpot

+2 more reviewers

@MrYamousMrYamousMrYamous left review comments

@dsdeboerdsdeboerdsdeboer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

6 participants

@TimoBakx@OskarStark@alexandre-daubois@MrYamous@dsdeboer@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp