symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star2.3k

Add info about feature freeze period#19110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

OskarStark merged 1 commit intosymfony:6.3fromOskarStark:feature/add-info-about-feature-freeze-period

Nov 9, 2023

Merged

Add info about feature freeze period#19110

OskarStark merged 1 commit intosymfony:6.3fromOskarStark:feature/add-info-about-feature-freeze-period

Nov 9, 2023

Conversation

Copy link

Contributor

OskarStark commentedNov 3, 2023

Follows

[Messenger] Dispatch events before & after each handler symfony#52425 (comment)

carsonbot added the Status: Needs Review label

Nov 3, 2023

OskarStark self-assigned this

Nov 3, 2023

OskarStark requested review fromfabpot,javiereguiluz,nicolas-grekas andxabbuh

November 3, 2023 11:20

OskarStark mentioned this pull request

Nov 3, 2023

[Messenger] Dispatch events before & after each handlersymfony/symfony#52425

Open

Copy link

Contributor

BenMorel commentedNov 3, 2023

Thank you,@OskarStark!

Could the "short timeframe" be defined, likex weeks before release?
Could this be reflect on theSymfony Releases Calendar?

Copy link

ContributorAuthor

OskarStark commentedNov 3, 2023•
edited
Loading

Could the "short timeframe" be defined, like x weeks before release?

Not sure, as this is not ahard, more asoft deadline, lets ask@nicolas-grekas and@fabpot

Could this be reflect on theSymfony Releases Calendar?

Not sure it's worth, but possibly yes. But once done,@carsonbot could use that information

OskarStark added the Waiting team decisionRequest for comments from Symfony Docs Team members label

Nov 3, 2023

Copy link

Member

xabbuh commentedNov 3, 2023

We already document this as the "stabilization" period of two months here:https://symfony.com/doc/current/contributing/community/releases.html#development

Copy link

ContributorAuthor

OskarStark commentedNov 3, 2023•
edited
Loading

I agree, but this does not really explain what that mean for the contributor

94noni reviewed

Nov 3, 2023

View reviewed changes

contributing/code/pull_requests.rst Outdated

		@@ -147,6 +147,15 @@ work:
		for the ``5.4`` branch, the PR will also be applied by the core team on
		all the ``6.x`` branches that are still maintained.

		.. warning::

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

isnt "info" enough?
"warning" seem to strong and devs may be not opening new PR :s

what about:

during a short period of time prior to the release of a new symfony major version, the symfony repository
is feature freeze. Your pull requests are still more than welcome nonetheless they must target the next major version

something like that ^^

alexandre-daubois reviewed

Nov 6, 2023

View reviewed changes

contributing/code/pull_requests.rst Outdated

		@@ -147,6 +147,15 @@ work:
		for the ``5.4`` branch, the PR will also be applied by the core team on
		all the ``6.x`` branches that are still maintained.

		.. warning::

		For a short timeframe before a new major version is released, we are in a

Copy link

Member

alexandre-dauboisNov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it only before a major version? I have the feeling that I already saw some feature freeze for minor version to stabilize the whole thing, but I may be wrong 🤔

Copy link

Member

fabpot commentedNov 6, 2023

I don't think that this is needed as this is already described here:https://symfony.com/doc/current/contributing/community/releases.html#development

Maybe adding a link to this paragraph would be enough.

Copy link

Member

wouterj commentedNov 6, 2023•
edited
Loading

I agree that we should not duplicate the release cycle documentation, but I like mentioning it on this page. It's common to see contributors confused what they should do with their PR during this phase. What about replacing the strong warning with a more subtle paragraph like:

During the:ref:`stabilization phase<contributing-release-development>`, the development branch is infeature freeze. Please help the community prepare for the new version release. If you want to submit anew feature pull request, you should target the next version. For example, if ``6.3`` reached featurefreeze, new features should target ``6.4``. If the ``6.4`` branch does not yet exists, target ``6.3``and rebase your pull requests once the branch is created.

(second sentence may be removed, I can't help myself pushing everyone to not focus on writing new features during these 2 months 😛 )

Copy link

Member

fabpot commentedNov 6, 2023

I agree that we should not duplicate the release cycle documentation, but I like mentioning it on this page. It's common to see contributors confused what they should do with their PR during this phase. What about replacing the strong warning with a more subtle paragraph like:
During the :ref:`stabilization phase <contributing-release-development>`, the development branch is infeature freeze. Please help the community prepare for the new version release. If you want to submit anew feature pull request, you should target the next version. For example, if ``6.3`` reached featurefreeze, new features should target ``6.4``. If the ``6.4`` branch does not yet exists, target ``6.3``and rebase your pull requests once the branch is created.
(second sentence may be removed, I can't help myself pushing everyone to not focus on writing new features during these 2 months 😛 )

That works for me