Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[PHPUnitBridge] Allow setting the locale usingSYMFONY_PHPUNIT_LOCALE env var#19089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
SYMFONY_PHPUNIT_LOCALE env varSYMFONY_PHPUNIT_LOCALE env var8644ada to5be90aaCompareOskarStark commentedOct 27, 2023
Thank you Alexandre. |
VincentLanglet commentedOct 27, 2023
Would it be worth adding that disable the behavior, since returns the locale instead of setting it |
alexandre-daubois commentedOct 27, 2023
I'm not sure, because this is something that touches the internals of the bridge, which we do not document. Also, if someone wants to disable this new behavior, it'll remove the env var I guess. So I'm not sure this is something we should add as it may bring more confusion than anything else 🤔 |
VincentLanglet commentedOct 27, 2023
No, removing the env var won't disable the behavior, it will set the default By default the bridge set a consistent locale and there was no way to avoid this behavior. Then, we added the feature to select another local. When looking at the bridge issues, some people were complaining about the fact a locale was set, but none complained about the locale set. So this feature might be used more often to disable the behavior rather than changing the locale. |
… by the bridge (alexandre-daubois)This PR was merged into the 6.4 branch.Discussion----------[PHPUnitBridge] Add a note to disable the locale forcing by the bridgeFollowing#19089 (comment), cc `@VincentLanglet` 🙂Commits-------226b0ed [PHPUnitBridge] Add a note to disable the locale forcing by the bridge
Fix#19088