Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Serializer] Deprecate annotations#19046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e239c82 tof53d88fCompare| use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory; | ||
| use Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader; | ||
| $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
or remove it in 7.0?
alexandre-dauboisOct 24, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is still valid in 6.4 so I think itshould stay with the deprecation message below. If someone wants to migrate from one to another, this person may search forAnnotationLoader in the doc to understand how to migrate
I would remove it in 7.0 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you open a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep 🙂
OskarStark commentedOct 24, 2023
Thank you Alexandre. |
Fix#19036