Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[FrameworkBundle][HttpKernel] Introduce$buildDir argument toWarmableInterface::warmup to warm read-only artefacts inbuild_dir#19041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
reference/dic_tags.rst Outdated
| If you don't need to preload anything, return an empty array. | ||
| If you don't need to preload anything, return an empty array. If read-only | ||
| artefacts need to be created, you can store them in a different directory | ||
| with the ``buildDir`` argument of the ``warmUp()`` method. |
OskarStarkOct 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| with the ``buildDir`` argument of the ``warmUp()`` method. | |
| with the ``$buildDir`` argument of the ``warmUp()`` method. |
Not sure if we should use argument or parameter here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's use parameter everywhere 🙂
reference/dic_tags.rst Outdated
| .. versionadded:: 6.4 | ||
| The ``buildDir`` argument of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| The ``buildDir``argument of the | |
| The ``$buildDir``parameter of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A function signature contains parameters and is called with arguments
…ableInterface::warmup` to warm read-only artefacts in `build_dir`
efdd2de to2026c73CompareGood rule of thumb, I always get the two mixed up 😅 |
Thank you Alexandre. |
Thank you@alexandre-daubois ! It was on my todo-list for today, but you beat me to it 😅 |
Oops, my bad! I'll ask you next time so you can take the time to do it 🙂 |
Fix#19034