Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[RateLimiter] AddSlidingWindowLimiter::reserve()#18962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can try to use a versionadded and a separate deprecated directive if that works. Otherwise you can ignore the specific rule for this file.
You can provide a follow up PR for 7.0 after this where we remove the directive and the ignored rule again.
bbd92c9 tob5b0093Comparealexandre-daubois commentedOct 2, 2023
Tried a bit of rewording here. Once merged, I'll send a PR to remove all |
javiereguiluz commentedOct 4, 2023
A very nice contribution with all the useful deprecation messages. Thanks a lot Alex! |
Uh oh!
There was an error while loading.Please reload this page.
Fix#18956
Doctor-RST's complaining but I'm not 100% sure how to adapt in this case, as it is a mix of deprecation and versionadded 🤔