Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Clock] AddDatePoint#18932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:6.4fromalexandre-daubois:date-point
Sep 29, 2023
Merged

Conversation

@alexandre-daubois
Copy link
Member

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would swap the main purpose and the "big advantage" below. (I would also not use "big advantage", that's too subjective)
The main feature of the class is to be bound to the global clock managed by the component, the strictness (and consist behavior across versions of PHP) is bonus.
We might also tell that all clock implementations in the component return a DatePoint?

SzymonKaminski reacted with thumbs up emoji
@alexandre-daubois
Copy link
MemberAuthor

Thank you for your comment, I reworded the whole section by taking your feedback into account 👍

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks, here are some proposals

@alexandre-dauboisalexandre-dauboisforce-pushed thedate-point branch 2 times, most recently from0c23e95 to38698e2CompareSeptember 27, 2023 12:35
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM once my two remaining comments are handled, thanks!

alexandre-daubois reacted with rocket emoji
@OskarStark
Copy link
Contributor

Thank you Alexandre.

@OskarStarkOskarStark merged commit79ea13c intosymfony:6.4Sep 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@wouterjwouterjwouterj approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[Clock] AddDatePoint: an immutable DateTime implementation with stri…

5 participants

@alexandre-daubois@OskarStark@nicolas-grekas@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp