Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Clock] AddDatePoint#18932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Clock] AddDatePoint#18932
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cd23d15 to5d75dcdCompare
nicolas-grekas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would swap the main purpose and the "big advantage" below. (I would also not use "big advantage", that's too subjective)
The main feature of the class is to be bound to the global clock managed by the component, the strictness (and consist behavior across versions of PHP) is bonus.
We might also tell that all clock implementations in the component return a DatePoint?
5d75dcd to4aca469Comparealexandre-daubois commentedSep 27, 2023
Thank you for your comment, I reworded the whole section by taking your feedback into account 👍 |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks, here are some proposals
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
0c23e95 to38698e2CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM once my two remaining comments are handled, thanks!
38698e2 to2a88325CompareUh oh!
There was an error while loading.Please reload this page.
2a88325 tof14bc14CompareOskarStark commentedSep 29, 2023
Thank you Alexandre. |
Fix#18930