[Translation] Fix`default-path` XML config#18872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:5.4fromHeahDude:fix/translation-default-path-config

Sep 19, 2023

Merged

[Translation] Fix`default-path` XML config#18872

javiereguiluz merged 1 commit intosymfony:5.4fromHeahDude:fix/translation-default-path-config

Sep 19, 2023

Conversation

Copy link

Contributor

HeahDude commentedSep 16, 2023•
edited
Loading

Note: we should wait forsymfony/symfony#51671 to be merged first.

[Translator] Fixdefault-path XML config

8f381f6

carsonbot added Status: Needs Review Translation labels

Sep 16, 2023

carsonbot added this to the5.4 milestone

Sep 16, 2023

carsonbot changed the title~~[Translator] Fixdefault-path XML config~~[Translation] Fixdefault-path XML config

Sep 16, 2023

HeahDude mentioned this pull request

Sep 16, 2023

[FrameworkBundle] Fix support fortranslator.default_path in XMLsymfony/symfony#51671

Merged

OskarStark added the Waiting Code MergeDocs for features pending to be merged label

Sep 16, 2023

carsonbot modified the milestones:5.4,next

Sep 16, 2023

nicolas-grekas added a commit to symfony/symfony that referenced this pull request

Sep 19, 2023

bug#51671[FrameworkBundle] Fix support for `translator.default_path…

ac2e41f

…` in XML (HeahDude)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Fix support for `translator.default_path` in XML| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | ~| License       | MIT| Doc PR        |symfony/symfony-docs#18872The docs is currently wrong assuming there is an element `default-path` using XML config,https://symfony.com/doc/current/translation.html#configuration.It appears it's missing in the XSD, but IMO it should be added as an attribute.Commits-------3534118 [Translator] Fix support for `default_path` in XML