Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[AssetMapper] Add docs forimportmap:install command#18785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -233,8 +233,11 @@ If you want to download the package locally, use the ``--download`` option: | ||
| $ php bin/console importmap:require bootstrap --download | ||
| This will download the package into an ``assets/vendor/`` directory and update | ||
| the ``importmap.php`` file to point to it. You can either commit this directory | ||
| to your repository, or ignore the directory in your ``.gitignore`` config file. | ||
| If the directory is ignored, you can run the | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Is it « can » or « must » ? Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think in 6.4, we should change the workflow from "must commit" to "should ignore". Let's rework the language for that - it'll be just like In fact, would you mind opening a new recipe PR for AssetMapper 6.4 that includes Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. While merging I did some tweaks according to your comments. See5909e6b | ||
| ``php bin/console importmap:install`` command to download the files on other | ||
| computers if some files are missing. | ||
| ..note:: | ||