Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[AssetMapper] Add docs forimportmap:install command#18785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| your repository. | ||
| the ``importmap.php`` file to point to it. You can either commit this directory | ||
| to your repository, or ignore the directory in your ``.gitignore`` config file. | ||
| If the directory is ignored, you can run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it « can » or « must » ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think in 6.4, we should change the workflow from "must commit" to "should ignore". Let's rework the language for that - it'll be just likecomposer install: it's a "must" (assuming you are downloading assets locally).
In fact, would you mind opening a new recipe PR for AssetMapper 6.4 that includesassets/vendor/ in.gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While merging I did some tweaks according to your comments. See5909e6b
importmap:install commandjaviereguiluz commentedAug 28, 2023
@jmsche thanks for this contribution! |
Hi, this PR adds docs for the new
importmap:installcommand added bysymfony/symfony#51351.