Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] Add#[AutowireLocator] attribute#18775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kbond left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this@alexandre-daubois!
| use Symfony\Component\DependencyInjection\Attribute\AutowireLocator; | ||
| use Symfony\Contracts\Service\ServiceSubscriberInterface; | ||
| class CommandBus implements ServiceSubscriberInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| class CommandBus implements ServiceSubscriberInterface | |
| class CommandBus |
This should be removed, correct? (Same with below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed! That's updated 🙂
| use App\CommandHandler\FooHandler; | ||
| use Psr\Container\ContainerInterface; | ||
| use Symfony\Component\DependencyInjection\Attribute\AutowireLocator; | ||
| use Symfony\Contracts\Service\ServiceSubscriberInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| use Symfony\Contracts\Service\ServiceSubscriberInterface; |
5385339 toccaab77Compare| } | ||
| Just like with the ``getSubscribedServices()`` method, it is possible | ||
| to define aliased services thanks to named argument, as well as optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| to define aliased services thanks to namedargument, as well as optional | |
| to define aliased services thanks to namedarguments, as well as optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updated, thanks 🙂
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM thanks
ccaab77 to408bf95Comparejaviereguiluz commentedAug 28, 2023
Another nice new feature and another perfect contribution. Thanks Alex ... and thanks to reviewers too! |
Fix#18774