Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Workflow] Allow using public properties for the marking store#18658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lyrixx commentedAug 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can you add a note about the context: Context is not supported with property. So, if one want to use the context, they must use a public method. But the following code works: class S{public$marking;// Used for readingprivate$context;publicfunctionsetMarking($marking,$context) {// used for setting... }} |
a71406d to4bd3c04Comparealexandre-daubois commentedAug 1, 2023
Pushed a new version, what do you think? 🙂 |
lyrixx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perfect 💛
Thank you so much for all your contributions 😍
workflow.rst Outdated
| } | ||
| } | ||
| ..tip:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we can use a regular paragraph here, it is too long for a tip IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right, updated 🙂
4bd3c04 to1e6ec52Comparejaviereguiluz commentedAug 1, 2023
Another great combo of nice feature + nice contribution + nice review. Thank you all! |
Fix#18656