Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Form] Support Translatable Enum#18599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
derrabus added a commit to symfony/symfony that referenced this pull requestJul 24, 2023
This PR was squashed before being merged into the 6.4 branch.Discussion----------[Form] Support Translatable Enum| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#50919| License | MIT| Doc PR |symfony/symfony-docs#18599This PR introduce support for Enum implementing `TranslatableInterface` in `EnumType`.Example of use:```php$builder->add('textAlign', EnumType::class, [ 'class' => TextAlign::class,])``````phpuse Symfony\Contracts\Translation\TranslatableInterface;use Symfony\Contracts\Translation\TranslatorInterface;enum TextAlign: int implements TranslatableInterface{ case Left = 1; case Center = 2; case Right = 3; public function trans(TranslatorInterface $translator, string $locale = null): string { // Translate enum from name (Left, Center or Right) return $translator->trans($this->name, locale: $locale); // Translate enum from custom labels return match ($this) { self::Left => $translator->trans('Left aligned', locale: $locale), self::Center => $translator->trans('Centered', locale: $locale), self::Right => $translator->trans('Right aligned', locale: $locale), }; }}```Commits-------65f26da [Form] Support Translatable Enum
symfony-splitter pushed a commit to symfony/form that referenced this pull requestJul 24, 2023
This PR was squashed before being merged into the 6.4 branch.Discussion----------[Form] Support Translatable Enum| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fixsymfony/symfony#50919| License | MIT| Doc PR |symfony/symfony-docs#18599This PR introduce support for Enum implementing `TranslatableInterface` in `EnumType`.Example of use:```php$builder->add('textAlign', EnumType::class, [ 'class' => TextAlign::class,])``````phpuse Symfony\Contracts\Translation\TranslatableInterface;use Symfony\Contracts\Translation\TranslatorInterface;enum TextAlign: int implements TranslatableInterface{ case Left = 1; case Center = 2; case Right = 3; public function trans(TranslatorInterface $translator, string $locale = null): string { // Translate enum from name (Left, Center or Right) return $translator->trans($this->name, locale: $locale); // Translate enum from custom labels return match ($this) { self::Left => $translator->trans('Left aligned', locale: $locale), self::Center => $translator->trans('Centered', locale: $locale), self::Right => $translator->trans('Right aligned', locale: $locale), }; }}```Commits-------65f26dad9c [Form] Support Translatable Enum
derrabus suggested changesJul 24, 2023
Uh oh!
There was an error while loading.Please reload this page.
Member
derrabus commentedJul 24, 2023
Code PR has been merged. |
Member
xabbuh commentedJul 26, 2023
We also need a |
ContributorAuthor
Seb33300 commentedJul 27, 2023
Added |
Uh oh!
There was an error while loading.Please reload this page.
OskarStark approved these changesJul 27, 2023
Contributor
OskarStark commentedJul 27, 2023
Thanks for your work on this new feature! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation forsymfony/symfony#50931