Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added cookbook entry on dynamic form generation based on services#1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
khepin wants to merge2 commits intosymfony:masterfromkhepin:dyna_forms

Conversation

khepin
Copy link
Contributor

No description provided.

@stof
Copy link
Member

111 files changed ? Looks like you messed your commits

@wouterj
Copy link
Member

I have commented on the first commit, because the second commit makes things really bad...

You should create a new PR with only the first commit, maybe you should create a new branch and only add the article and create a PR based on that branch.

This isn't a2.1 feature and it should be based on and merged into the2.0 branch.

@khepin
Copy link
ContributorAuthor

Yikes! Messed up my commits indeed! ... I'm coming back with a cleaner commit asap!

@khepin
Copy link
ContributorAuthor

I made the changes suggested by@wouterj and opened a new clean pull request based on the 2.0 branch.

So I am closing this one.

@khepinkhepin closed thisOct 22, 2012
@khepin
Copy link
ContributorAuthor

New PR is#1842

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@khepin@stof@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp