Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyInfo] Fix PhpStanExtractor added version#18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.2fromcolinodell:patch-3
Jun 12, 2023

Conversation

@colinodell
Copy link
Contributor

PhpStanExtractor was actually added in 5.4:symfony/symfony#40457 (comment)

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update thePR base branch to target one of these branches instead? 5.4, 6.2, 6.3, 6.4, 7.0.

Cheers!

Carsonbot

@carsonbotcarsonbot added this to the6.1 milestoneJun 9, 2023
@colinodellcolinodell changed the base branch from6.1 to6.2June 9, 2023 19:45
@MrYamous
Copy link
Contributor

Nice catch, i think it can be rebased on 5.4 :)

@colinodell
Copy link
ContributorAuthor

i think it can be rebased on 5.4

This section of the documentation wasn't added until 6.1:#16955 (comment) I'm not sure why that decision was made, so I'm hesitant to backport this to 5.4.

@javiereguiluzjaviereguiluz modified the milestones:6.1,6.2Jun 12, 2023
@carsonbotcarsonbot changed the titleFix PhpStanExtractor added version[PropertyInfo] Fix PhpStanExtractor added versionJun 12, 2023
@javiereguiluzjaviereguiluz merged commitdb084b4 intosymfony:6.2Jun 12, 2023
@javiereguiluz
Copy link
Member

Colin, thanks a lot for fixing this. Sadly, this was a bit tricky:

  • As Matthieu said, the best possible solution is to merge this in the (still supported) 5.4 branch
  • But as you said, this section was not added to 5.4, so it's cumbersome to move both the contents and theversionadded directive
  • Also, in 6.x docs we can't have5.x versionadded directives (in 7.x we can't have 6.x versionadded, etc.)

So, while merging, I just removed the entireversionadded directive (see7647318) because it's no longer needed in 6.x docs.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@MrYamousMrYamousMrYamous approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@colinodell@carsonbot@MrYamous@javiereguiluz

[8]ページ先頭

©2009-2025 Movatter.jp