Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] OIDC user info token handler client#18354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.3fromvincentchalamon:fix/security/oidc_user_info-token_handler-client
Jul 4, 2023
Merged

[Security] OIDC user info token handler client#18354

javiereguiluz merged 1 commit intosymfony:6.3fromvincentchalamon:fix/security/oidc_user_info-token_handler-client
Jul 4, 2023

Conversation

vincentchalamon
Copy link
Contributor

No description provided.

nicolas-grekas added a commit to symfony/symfony that referenced this pull requestMay 30, 2023
…ler client (vincentchalamon)This PR was squashed before being merged into the 6.3 branch.Discussion----------[SecurityBundle] Fix configuring OIDC user info token handler client| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        |symfony/symfony-docs#18354Cf.#50453 (comment)Commits-------23c9e17 [SecurityBundle] Fix configuring OIDC user info token handler client
@vincentchalamon
Copy link
ContributorAuthor

@nicolas-grekas are you aware of this issue?

image

@nicolas-grekas
Copy link
Member

Needs a fix indeed...

@vincentchalamon
Copy link
ContributorAuthor

OK found it:security.access_token_handler.oidc.signature is declared as an abstract service AND a factory, but I don't think it's possible to combine both as anabstract factory:

->set('security.access_token_handler.oidc.signature', Algorithm::class)    ->abstract()    ->factory([SignatureAlgorithmFactory::class,'create'])    ->args([abstract_arg('signature algorithm'),    ])->set('security.access_token_handler.oidc.signature.ES256',ES256::class)    ->parent('security.access_token_handler.oidc.signature')    ->args(['index_0' =>'ES256'])

@nicolas-grekas is there any way to declare anabstract factory, or should I call the factory on each service declaration?

@nicolas-grekas
Copy link
Member

Strange, I would expect this to work. I can have a look a bit later.

@javiereguiluz
Copy link
Member

Thank you Vincent.

@javiereguiluzjaviereguiluz merged commit42c3280 intosymfony:6.3Jul 4, 2023
@vincentchalamonvincentchalamon deleted the fix/security/oidc_user_info-token_handler-client branchJuly 4, 2023 13:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees
No one assigned
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

4 participants
@vincentchalamon@nicolas-grekas@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp