Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update parameter to compile-time prefix#18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.3fromyesdevnull:6.3
May 24, 2023

Conversation

@yesdevnull
Copy link
Contributor

Use the new compile-time only prefix for build parameters.

Seesymfony/symfony#47680 for the original feature implementation.

@carsonbotcarsonbot added this to the6.3 milestoneMay 24, 2023
@carsonbotcarsonbot changed the title[Performance] Update parameter to compile-time prefixUpdate parameter to compile-time prefixMay 24, 2023
@yesdevnull
Copy link
ContributorAuthor

Apologies if this should've been tagged with[DependencyInjection] and[HttpKernel], I opted to use the documentation-specific location tag.

@javiereguiluz
Copy link
Member

Dan, thanks for this contribution.

Before merging this, let me ask@nicolas-grekas because I'm not sure if anything will break when applying this to a parameter used by Symfony itself. Thanks!

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

javiereguiluz reacted with thumbs up emoji
@javiereguiluz
Copy link
Member

Dan, thanks for fixing this and congrats on your first Symfony Docs contribution 🎉

Thanks also to Nicolas for the review.

yesdevnull and andreybolonin reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@yesdevnull@javiereguiluz@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp