Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Waiting Code Merge] Update reference/configuration/framework.rst for new serializer service#1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR is related to this onesymfony/symfony#5347.
| and :class:`Symfony\\Component\\Serializer\\Encoder\\XmlEncoder) | ||
| and one normalizer (:class:`Symfony\\Component\\Serializer\\Normalizer\\GetSetMethodNormalizer`). | ||
| You can add more normalizers and/or encoders by tagging them as `serializer.encoder` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You need to use a double backtrick (`) for inline code in RsT, instead of a single backtrick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems to work fine with a single backtick here,https://github.com/symfony/symfony-docs/blob/master/components/serializer.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, it does work but isn't the way to go. A single backtick is to indicate a link:
Go to the `symfony website<http://symfony.com/>`And double backtick is for inline code block:
Create a ``Page`` entity...More information on the Symfony docs:http://symfony.com/doc/master/contributing/documentation/format.html#restructuredtext
you also need to update the reference with the new DIC tags |
Adding tags to the tag list reference
Done! |
Changing backticks
@loalf in respond to your (removed) answer. The part you linked to (adding-links) is about links, not inline code. As I said, links are wrapped in single backtick and because of that inline code is wrapped in double backticks. By the way, good job! 👍 |
That´s why I removed the comment, :). For some reason I thought you were talking about the code a couple of lines before not those. I realized of it after I put my comment. My apologies. |
The GetSetMethodNormalizer is not loaded by default
| and :class:`Symfony\\Component\\Serializer\\Encoder\\XmlEncoder`) | ||
| but none normalizer. The :class:`Symfony\\Component\\Serializer\\Normalizer\\GetSetMethodNormalizer` is broken by design | ||
| so you are required to load it under your responsability. You can do creating a new service and tagging it appropiately. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should probably provide the configuration to enable this service. That would also serve as a generic example.
…tch-1Also contains tweaks to#1829Conflicts:reference/configuration/framework.rst
…k and linked to that from everywhere else
Hi@weaverryan, thanks for the heads-up. I am quite happy with both, moving some to its dedicated cookbook and your grammar facelift, :). Thanks! |
This PR is related to this onesymfony/symfony#5347.