Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[DependencyInjection] Add theconstructor
option to service definition#18070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18a36c7
to6040cfe
Comparefabpot added a commit to symfony/symfony that referenced this pull requestMar 31, 2023
…utoconfigure]` (alexandre-daubois)This PR was merged into the 6.3 branch.Discussion----------[DependencyInjection] Add `constructor` option to `#[Autoconfigure]`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | _NA_| License | MIT| Doc PR |symfony/symfony-docs#18070Following [this discussion](https://twitter.com/nicolasgrekas/status/1634259754104025088?s=20) on Twitter, here is my try to use service factories with attributes. This PR adds the `constructor` option to the `Autoconfigure` attribute, and more generally, the `constructor` option on service definitions.This allows to write services using a factory this way:```php#[Autoconfigure(constructor: 'create')]class FactoryAttributeService{ public function __construct(private readonly string $bar) { } public function getBar(): string { return $this->bar; } public static function create(string $foo = 'foo'): static { return new self($foo); }}```Commits-------8dda3f0 [DependencyInjection] Add `constructor` option to services declaration and to `#[Autoconfigure]`
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestMar 31, 2023
…utoconfigure]` (alexandre-daubois)This PR was merged into the 6.3 branch.Discussion----------[DependencyInjection] Add `constructor` option to `#[Autoconfigure]`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | _NA_| License | MIT| Doc PR |symfony/symfony-docs#18070Following [this discussion](https://twitter.com/nicolasgrekas/status/1634259754104025088?s=20) on Twitter, here is my try to use service factories with attributes. This PR adds the `constructor` option to the `Autoconfigure` attribute, and more generally, the `constructor` option on service definitions.This allows to write services using a factory this way:```php#[Autoconfigure(constructor: 'create')]class FactoryAttributeService{ public function __construct(private readonly string $bar) { } public function getBar(): string { return $this->bar; } public static function create(string $foo = 'foo'): static { return new self($foo); }}```Commits-------8dda3f0b77 [DependencyInjection] Add `constructor` option to services declaration and to `#[Autoconfigure]`
I totally missed this one. Thanks for this contribution Alex! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tosymfony/symfony#49665