Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Serializer] Add feature description forAbstractNormalizer::REQUIRE_ALL_PROPERTIES context option#17979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
AbstractNormalizer::PREVENT_NULLABLE_FALLBACK context optionAbstractNormalizer::REQUIRE_ALL_PROPERTIES context option…listed in the input (Christian Kolb)This PR was merged into the 6.3 branch.Discussion----------[Serializer] Add flag to require all properties to be listed in the input| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#49504| License | MIT| Doc PR |symfony/symfony-docs#17979The PR#40522 introduced a fallback for nullable properties to be set to `null` when they aren't provided as parameters.A drawback of that approach is that it easier for bugs to appear through typos or renamings of those properties. I think the current implementation makes perfect sense as a default. Therefore, this PR introduces a new context flag that prevents that fallback behaviour. This way nothing changes for existing systems, but for people wanting more control, it's possible to set a flag.### Example```phpfinal class Product{ public function __construct( public string $name, public ?int $costsInCent, ) { }}// This works and results in $costsInCent as null$product = $this->serializer->deserialize( '{"name": "foo"}', Product::class, JsonEncoder::FORMAT,);// When using the flag, only the following JSON is valid$product = $this->serializer->deserialize( '{"name": "foo", "costsInCent": null}', Product::class, JsonEncoder::FORMAT, [ AbstractNormalizer::PREVENT_NULLABLE_FALLBACK => true, ],);// This would result in an error due to missing parameters$product = $this->serializer->deserialize( '{"name": "foo"}', Product::class, JsonEncoder::FORMAT, [ AbstractNormalizer::PREVENT_NULLABLE_FALLBACK => true, ],);```Commits-------d62410a [Serializer] Add flag to require all properties to be listed in the input
christian-kolb commentedMay 5, 2023
@OskarStark The connected PR was just merged 🙂 |
xabbuh commentedNov 21, 2023
Thank you@christian-kolb. |
This PR adds the feature description for the new context flag for the Serializer component introduced here:symfony/symfony#49553