[Config] [Configuration] Add enum case as service parameter example#17910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:6.2fromalexandre-daubois:enum-case-service-parameter

Feb 17, 2023

Merged

[Config] [Configuration] Add enum case as service parameter example#17910

javiereguiluz merged 1 commit intosymfony:6.2fromalexandre-daubois:enum-case-service-parameter

Feb 17, 2023

Conversation

Copy link

Member

alexandre-daubois commentedFeb 16, 2023

Fixes#17407

[Configuration] Add enum case as service parameter example

701f74b

carsonbot added the Status: Needs Review label

Feb 16, 2023

OskarStark approved these changes

Feb 17, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 17, 2023

javiereguiluz added the Config label

Feb 17, 2023

carsonbot changed the title~~[Configuration] Add enum case as service parameter example~~[Config] [Configuration] Add enum case as service parameter example

Feb 17, 2023

javiereguiluz added this to the6.2 milestone

Feb 17, 2023

Copy link

Member

javiereguiluz commentedFeb 17, 2023

Everybody loves enums 😍 so this is nice! Thanks Alex.

javiereguiluz merged commitb686cf5 intosymfony:6.2

Feb 17, 2023

stof mentioned this pull request

Oct 15, 2024

[Config] Fix the XML configuration example for enums#20329

Merged

javiereguiluz added a commit that referenced this pull request

Oct 15, 2024

minor#20329[Config] Fix the XML configuration example for enums (stof)

d0cffd5

This PR was merged into the 6.4 branch.Discussion----------[Config] Fix the XML configuration example for enumsThere is no `type="enum"` in the XML file loader.The bad example was introduced in#17910. However, the issue it was fixing was about a change in Symfony for **PHP** config files only. The Yaml and XML file loaders don't have any dedicated syntax for enums (but of course, the Yaml component itself does, which is what is used in the Yaml example)Commits-------2f00687 Fix the XML configuration example for enums