Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarExporter] AddHydrator section#17884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

Fixes#16827

@javiereguiluz
Copy link
Member

Alex, thanks a lot for this contribution. The VarExporter component doesn't receive many doc PRs ... so we appreciate them a lot!

While merging we did some tweaks (see013b6d1):

  • Adding the.. _instantiating-php-classes: reference is needed because we changed the headline, so the anchor link will change. This will "break" direct links to that section:https://symfony.com/doc/current/components/var_exporter.html#instantiating-php-classes (that's why we always add a hidden reference to the previous headline contents when we change them)
  • I reversed some changes in the comments that capitalized the first letter:// Creates ... vs// creates ... Of course your proposal is not wrong ... but we mostly use the second option because comments are usually one line and the capital letter looks unbalanced with the following code, which usually starts with a lowercase letter or the$ variable indicator. In the future we can discuss about changing this 🙏

Thanks!

alamirault and alexandre-daubois reacted with heart emoji

@alexandre-daubois
Copy link
MemberAuthor

Amazing, thanks@javiereguiluz!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

1 more reviewer

@alamiraultalamiraultalamirault left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[VarExporter] Add Hydrator::hydrate() and preserve PHP referenc…

4 participants

@alexandre-daubois@javiereguiluz@alamirault@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp