Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] [LazyServices] Add#[Autoconfigure] attribute mention#17784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[DependencyInjection] [LazyServices] Add#[Autoconfigure] attribute mention#17784
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Can you also please remove all occurrences of ProxyManager from the doc v6.2? It's not needed anymore.
alexandre-daubois commentedJan 21, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Of course! I'll take care of this within the PR about the 2 traits 👍 |
#[Autoconfigure] attribute mention#[Autoconfigure] attribute mentionjaviereguiluz commentedJan 23, 2023
Thanks! |
…documentation (alexandre-daubois)This PR was merged into the 6.2 branch.Discussion----------[VarExporter] Add `LazyGhostTrait` and `LazyProxyTrait` documentationFriendly ping `@nicolas`-grekas for your review on this technical one. I based myself a lot on the README of VarExporter that was filled-in (thanks for this, that was some priceless help here!) and your SymfonyCon talk.About your comment#17784 (review), it seems that occurrences of ProxyManager have already been removed for 6.2 and above. 🙂Fixes#16970Fixes#17249Commits-------ae0f85f [VarExporter] Add `LazyGhostTrait` and `LazyProxyTrait` documentation
While watching@nicolas-grekas' SymfonyCon talk about lazy objects to give a try to#16970, he told that the documentation about
#[Autoconfigure(lazy: ...)]was missing. So here it is 😄