Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Notifier] do not display todo doc on site#17627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark commentedDec 28, 2022
This should be parsed differently by the docs-builder@weaverryan |
MrYamous commentedDec 28, 2022
Do you think it's a parsing issue ? Syntax seems to be incomplete regarding others todo block |
OskarStark commentedDec 28, 2022
Yes, because before, when we use |
nikophil commentedDec 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hello, the problem comes from therst parser. rst language reference says comments could look like this, which works with the parser: .. This is a commentor this, which is not considered as a comment and is a bug in the parser .. this is a comment they don't give an example for this kind of block (not evenin sphinx doc) .. first comment still a comment in the same block but they do provide a "syntax diagram" which makes me think this should also be considered as a comment: Still, if Sphynx did consider the later as a block comment, maybe this behavior could land in the parser as well. .. I am a comment and appear in grey I am also in grey, so I am a commentI am not in grey, because I am not a comment I've open a PR the rst repository |
nikophil commentedDec 29, 2022
PR is merged, let's wait for them to release the patch 😊 |
nikophil commentedDec 29, 2022
@OskarStark@weaverryan The PR has been released in 0.5.3 |
javiereguiluz commentedDec 30, 2022
Thanks Matthieu. |
javiereguiluz commentedDec 30, 2022
@nikophil thanks! I've tagged a new version of symfony/docs-builder too, so we'll get your latest fixes. |
I've noticed on bottom ofNotifier page a todo block displayed on site, just a small change to hide it