Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Remove not implemented behavior#17576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:5.4fromupyx:patch-1
Feb 21, 2023

Conversation

@upyx
Copy link
Contributor

Currently numeric keys are used, but it will be deprecated and changed in 7.0.

Deprecation:symfony/symfony#48686
New behavior:symfony/symfony#48653

@carsonbotcarsonbot added this to the5.4 milestoneDec 16, 2022
@OskarStarkOskarStark added the Waiting Code MergeDocs for features pending to be merged labelDec 20, 2022
@carsonbotcarsonbot modified the milestones:5.4,nextDec 20, 2022
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestDec 22, 2022
…ce_locator" config (upyx)This PR was merged into the 6.3 branch.Discussion----------[DependencyInjection] Deprecate integer keys in "service_locator" config| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | Deprecation befor#48653| License       | MIT| Doc PR        |symfony/symfony-docs#17576It deprecates undefined/wrong behaviour ofhttps://symfony.com/doc/current/service_container/service_subscribers_locators.html#defining-a-service-locatorCommits-------57c2365 [DependencyInjection] Deprecate integers keys in "service_locator" config
@upyx
Copy link
ContributorAuthor

upyx commentedJan 4, 2023

@OskarStark
Described behavior ("if the element has no key, the ID of the original service is used") hasn't been implemented. There is a bug in the documentation. Hovewer, I'm going to implement it in 7.0.

The PR removes a wrong description from older versions.

@OskarStarkOskarStark removed the Waiting Code MergeDocs for features pending to be merged labelJan 10, 2023
@OskarStarkOskarStark mentioned this pull requestJan 10, 2023
OskarStark added a commit that referenced this pull requestJan 10, 2023
This PR was merged into the 5.4 branch.Discussion----------Fix: TyposSpotted in*#17576Commits-------b93967a Fix: Typos
@xabbuhxabbuh modified the milestones:next,5.4Feb 3, 2023
Copy link
ContributorAuthor

@upyxupyx left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A typo has been fixed.

@OskarStark
Copy link
Contributor

After we merge this in5.4 can you submit a PR with the new behavior for6.3?

@upyx
Copy link
ContributorAuthor

After we merge this in5.4 can you submit a PR with the new behavior for6.3?

It's have already been merged insymfony/symfony#48686. And it will be changed again in 7.0.

@OskarStark
Copy link
Contributor

Sorry I meant, create a PR against the Symfony docs repo

@upyx
Copy link
ContributorAuthor

Sorry I meant, create a PR against the Symfony docs repo

Yes, I will check the 6.3 branch and create a PR with necessary changes (if any).

OskarStark reacted with heart emojiOskarStark reacted with rocket emoji

@carsonbotcarsonbot changed the titleRemove not implemented behavior[DependencyInjection] Remove not implemented behaviorFeb 21, 2023
@javiereguiluz
Copy link
Member

Thanks Sergey ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluzjaviereguiluz merged commit1a37dd9 intosymfony:5.4Feb 21, 2023
alexandre-daubois added a commit to alexandre-daubois/symfony-docs that referenced this pull requestJun 21, 2023
javiereguiluz added a commit that referenced this pull requestJun 21, 2023
…lexandre-daubois)This PR was merged into the 6.2 branch.Discussion----------[DependencyInjection] Remove not implemented behaviorFollow-up#17576Commits-------b6a23b7 [DependencyInjection] Remove not implemented behavior
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

@wouterjwouterjAwaiting requested review from wouterj

@javiereguiluzjaviereguiluzAwaiting requested review from javiereguiluz

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@upyx@OskarStark@javiereguiluz@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp