Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Symfony CLI: document the .symfony.local.yaml config file#17562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:5.4fromjmsche:symfony_cli_config_file
Dec 27, 2022

Conversation

@jmsche
Copy link
Contributor

It seems there are some other options available for the.symfony.local.yaml configuration file:https://github.com/symfony-cli/symfony-cli/blob/862b631e07adc07a534ef5349cbffa6006b76f41/local/project/config.go#L34-L61

I think this PR documents all of them :)

@carsonbotcarsonbot added this to the5.4 milestoneDec 14, 2022
Comment on lines +299 to +303
# Sets domain1.wip and domain2.wip for the current project
proxy:
domains:
-domain1
-domain2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm wondering if this should not be moved to the proxy section 🤔.
Basically pin every part of the YAML to its dedicated feature section.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm open to move it if it's really wanted?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After thinking about this, I think it's better for now to keep all options of the config file in the same section, because it's not very long. In any case, if we realize that this is not working well, we can quickly update this in a future PR to do what@tucksaun suggested.

@javiereguiluz
Copy link
Member

Thank you@jmsche.

@javiereguiluzjaviereguiluz merged commit65d8034 intosymfony:5.4Dec 27, 2022
@jmschejmsche deleted the symfony_cli_config_file branchFebruary 20, 2023 13:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

+1 more reviewer

@tucksauntucksauntucksaun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jmsche@javiereguiluz@tucksaun@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp