Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Messenger] Add config optionarguments for amqp delay queues#17553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
thomasbeaujean wants to merge1 commit intosymfony:7.1Choose a base branch
base:7.1
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[Messenger] Add config optionarguments for amqp delay queues#17553
thomasbeaujean wants to merge1 commit intosymfony:7.1fromthomasbeaujean:amqp-connection-delay-arguments
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
arguments for amqp delay queuesCode merged in 7.1 |
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestFeb 7, 2024
…lay queues (Thomas Beaujean)This PR was merged into the 7.1 branch.Discussion----------[Messenger][Amqp] Add config option 'arguments' for delay queues| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#44186#46254| License | MIT| Doc PR |symfony/symfony-docs#17553Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created.The use case:- I do not know in advance the name of the queues (handled by env variables)- The queues are created automatically by symfony if needed- I need the deduplication plugin in both the queue and the associated delays queues (enabled with the x-message-deduplication argument)- I do not want to rewrite all delay arguments, I just want to be able to add or rewrite someThe associated configuration in messenger.yaml``` transports: async: dsn: '%env(MESSENGER_DSN)%' options: queues: '%env(MESSENGER_ASYNC_QUEUE_NAME)%': arguments: x-queue-type: 'classic' x-message-deduplication: true delay: arguments: x-queue-type: 'classic' x-message-deduplication: true```Commits-------94ee8a2 [Messenger] Add config option 'arguments' for delay queues
symfony-splitter pushed a commit to symfony/amqp-messenger that referenced this pull requestFeb 7, 2024
…lay queues (Thomas Beaujean)This PR was merged into the 7.1 branch.Discussion----------[Messenger][Amqp] Add config option 'arguments' for delay queues| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | Fix #44186 #46254| License | MIT| Doc PR |symfony/symfony-docs#17553Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created.The use case:- I do not know in advance the name of the queues (handled by env variables)- The queues are created automatically by symfony if needed- I need the deduplication plugin in both the queue and the associated delays queues (enabled with the x-message-deduplication argument)- I do not want to rewrite all delay arguments, I just want to be able to add or rewrite someThe associated configuration in messenger.yaml``` transports: async: dsn: '%env(MESSENGER_DSN)%' options: queues: '%env(MESSENGER_ASYNC_QUEUE_NAME)%': arguments: x-queue-type: 'classic' x-message-deduplication: true delay: arguments: x-queue-type: 'classic' x-message-deduplication: true```Commits-------94ee8a22b5 [Messenger] Add config option 'arguments' for delay queues
d90a84c to85aa210CompareHi, I rebase this doc PR on 7.1 (code merged in 7.1) |
@OskarStark@nicolas-grekas Has it been merged/released ? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created.