Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Adding deprecation information#17518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ..versionadded::6.2 | ||
| SensioFrameworkExtraBundle was deprecated in Symfony 6.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this true? I mean this is independent release, what bout instead of version added, mark a note or a caution that the bundle is now global inside symfony core as attributes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, seehttps://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/README.md
I don't know how the param converter works now. Just thought, adding a quick note is better than nothing :-)
xabbuh commentedDec 7, 2022
What about removing the whole section instead? |
javiereguiluz commentedDec 8, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Instead of removing the section entirely, we could briefly mention what's this (because I think it's very relevant to routing) and then link to the docs about the new |
wouterj commentedDec 8, 2022
I agree with Javier. And we might want to add a very small deprecated notice along the lines of "Prior to Symfony 6.2, this feature was provided by the SensioFrameworkExtraBundle." or something like that. (I can imagine that you might be a bit lost if you don't follow Symfony closely and can't find anything about the SensioFrameworkExtraBundle in the docs anymore) |
javiereguiluz commentedDec 8, 2022
I just saw that in another PR we have something like this but for another section. So, we could get inspiration from it:https://github.com/symfony/symfony-docs/pull/17530/files |
ThomasLandauer commentedDec 8, 2022
Sorry, I don't know enough to do this :-( |
javiereguiluz commentedMar 3, 2023
Closing in favor of#17999. |
No description provided.