Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Removal code-block php-annotation#17468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mdoutreluingne
Copy link
Contributor

Following#17223

@javiereguiluz
Copy link
Member

Thank you Maxime.

@javiereguiluzjaviereguiluz merged commit367bf3c intosymfony:6.1Nov 26, 2022
@mdoutreluingnemdoutreluingne deleted the remove_block_annotations branchNovember 26, 2022 12:45
@@ -38,54 +38,27 @@ use it as an annotation/attribute in other classes.

The ``#[HasNamedArguments]`` attribute was introduced in Symfony 6.1.

You can use ``#[HasNamedArguments]`` or ``getRequiredOptions()`` to make some constraint options required:
You can use ``#[HasNamedArguments]`` or ``getRequiredOptions()`` to make some constraint options required::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not sure if we really should mention this method any longer if we do not have an example for it anymore

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with you that this method is no longer used. Thanks
I have created a PR#17476

OskarStark added a commit that referenced this pull requestNov 30, 2022
…the example (mdoutreluingne)This PR was merged into the 6.1 branch.Discussion----------[Validator] `getRequiredOptions()` is no longer used in the exampleFollowing#17468I forgot to delete the method `getRequiredOptions()` as it is no longer used in the example and I have also removed the ``@Annotation`` because it was also no longer used in the example.Commits-------858cabc [Validator] Remove annotation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xabbuhxabbuhxabbuh left review comments

Assignees
No one assigned
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

4 participants
@mdoutreluingne@javiereguiluz@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp