Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Filesystem] Add docs forFilesystem::mirror() options#17394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
maxbeckers wants to merge1 commit intosymfony:6.4
base:6.4
Choose a base branch
Loading
frommaxbeckers:patch-symfony-25798

Conversation

maxbeckers
Copy link
Contributor

@maxbeckersmaxbeckers commentedOct 24, 2022
edited
Loading

This PR adds the options forFilesystem::mirror() including the renamed optioncopy_on_windows tofollow_symlinks with deprecation the old option. The related PR in Symfony project issymfony/symfony#47969.

@OskarStarkOskarStark changed the title[Filesystem] Add docs for Filesystem::mirror() options[Filesystem] Add docs forFilesystem::mirror() optionsOct 24, 2022
@OskarStark
Copy link
Contributor

Please target6.4 branch, thanks

@maxbeckersmaxbeckers changed the base branch from6.2 to6.4June 5, 2023 08:34
The following options can be passed:

* ``override`` (default: ``false``): If true, target files newer than origin files are overwritten (see :method:`Symfony\\Component\\Filesystem\\Filesystem::copy`)
* ``copy_on_windows`` (default: ``false``): Whether to copy files instead of links on Windows. Since symfony/filesystem 6.4 this option is deprecated, use follow_symlinks instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would remove the deprecated sentence here and ...

* ``override`` (default: ``false``): If true, target files newer than origin files are overwritten (see :method:`Symfony\\Component\\Filesystem\\Filesystem::copy`)
* ``copy_on_windows`` (default: ``false``): Whether to copy files instead of links on Windows. Since symfony/filesystem 6.4 this option is deprecated, use follow_symlinks instead.
* ``follow_symlinks`` (default: ``false``): Whether to copy files instead of links, where using symlinks in not working: windows, different drive, docker context not supporting symlinks.
* ``delete`` (default: ``false``): Whether to delete files that are not in the source directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

... add adeprecated:: directive here


* ``override`` (default: ``false``): If true, target files newer than origin files are overwritten (see :method:`Symfony\\Component\\Filesystem\\Filesystem::copy`)
* ``copy_on_windows`` (default: ``false``): Whether to copy files instead of links on Windows. Since symfony/filesystem 6.4 this option is deprecated, use follow_symlinks instead.
* ``follow_symlinks`` (default: ``false``): Whether to copy files instead of links, where using symlinks in not working: windows, different drive, docker context not supporting symlinks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Windows is capitalized in other rst files

Suggested change
* ``follow_symlinks`` (default: ``false``): Whether to copy files instead of links, where using symlinks in not working:windows, different drive, docker context not supporting symlinks.
* ``follow_symlinks`` (default: ``false``): Whether to copy files instead of links, where using symlinks in not working:Windows, different drive, docker context not supporting symlinks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@alamiraultalamiraultalamirault left review comments

Assignees
No one assigned
Labels
FilesystemStatus: Needs ReviewWaiting Code MergeDocs for features pending to be merged
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

4 participants
@maxbeckers@OskarStark@alamirault@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp