Allow specifying attributes for`RequestMatcher`#17388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

OskarStark merged 1 commit intosymfony:6.2frommdoutreluingne:fix_17377

Oct 24, 2022

Merged

Allow specifying attributes for`RequestMatcher`#17388

OskarStark merged 1 commit intosymfony:6.2frommdoutreluingne:fix_17377

Oct 24, 2022

Conversation

Copy link

Contributor

mdoutreluingne commentedOct 23, 2022•
edited by OskarStark
Loading

fixes#17377

Could you help me with the XML and PHP formats.

Add YAML example format
Add XML example format
Add PHP example format

carsonbot added Status: Needs Review SecurityBundle labels

Oct 23, 2022

carsonbot added this to the6.2 milestone

Oct 23, 2022

carsonbot changed the title~~[SecurityBundle][WIP] Allow specifying attributes forRequestMatcher~~[WIP] Allow specifying attributes forRequestMatcher

Oct 23, 2022

wouterj reviewed

Oct 23, 2022

View reviewed changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

The other formats would look like this:

<rulerole="ROLE_ADMIN">    <attributekey="_route">admin</attribute></rule><ruleroute="admin"role="ROLE_ADMIN"/>

(btw, you were actually right - XML was not yet supported for this setting, I've contributed a fix:symfony/symfony#47959 )

$security->accessControl()    ->roles(['ROLE_ADMIN'])    ->attributes(['_route' =>'admin']);$security->accessControl()    ->roles(['ROLE_ADMIN'])    ->route('admin');