Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Validator] Email - newallow-no-tld mode#17360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
wouterj merged 1 commit intosymfony:6.2fromguillemfondin:feature/new-standard-email-validationOct 23, 2022
Merged
[Validator] Email - newallow-no-tld mode#17360
wouterj merged 1 commit intosymfony:6.2fromguillemfondin:feature/new-standard-email-validationOct 23, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot added a commit to symfony/symfony that referenced this pull requestOct 20, 2022
…w3c official specification (guillemfondin)This PR was squashed before being merged into the 6.2 branch.Discussion----------[Validator] new email validation option to match with w3c official specification| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#47712| License | MIT| Doc PR |symfony/symfony-docs#17360## WHATEmail validator no matches with w3c official specication (that allow no tld) see#47712 for details.## WHYIn general, for public common usage, developers may not need to give users this liberty.Except for specific use case, (internal email for eg) in companies...## HOWAdd an option for accept tld (already exist `Email::VALIDATION_MODE_HTML5`) or not (official spec `Email::VALIDATION_MODE_HTML5_ALLOW_NO_TLD`)Commits-------23047d9 [Validator] new email validation option to match with w3c official specification
symfony-splitter pushed a commit to symfony/validator that referenced this pull requestOct 20, 2022
…w3c official specification (guillemfondin)This PR was squashed before being merged into the 6.2 branch.Discussion----------[Validator] new email validation option to match with w3c official specification| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | Fix #47712| License | MIT| Doc PR |symfony/symfony-docs#17360## WHATEmail validator no matches with w3c official specication (that allow no tld) see #47712 for details.## WHYIn general, for public common usage, developers may not need to give users this liberty.Except for specific use case, (internal email for eg) in companies...## HOWAdd an option for accept tld (already exist `Email::VALIDATION_MODE_HTML5`) or not (official spec `Email::VALIDATION_MODE_HTML5_ALLOW_NO_TLD`)Commits-------23047d978f [Validator] new email validation option to match with w3c official specification
wouterj approved these changesOct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
We should also add a.. versionadded:: 6.2 block after the list to indicate that this mode was introduced in 6.2.
Uh oh!
There was an error while loading.Please reload this page.
0bda552 to485d57eCompareThank you for documenting your code contribution,@guillemfondin! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeeRelated feature PR
As suggestedhere ; the actual description of
html5mode isn't consistent with the one provided by browsers. Browsers allow no tld,html5mode not.I proprose to move the actual description of
html5mode to the newallow-no-tldmode description, and clarify the subtlety (force .tld) of the actualhtml5mode.